Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oracle): add credentials secrets in jenkins for oracle terraform #2477

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Jun 8, 2022

add jenkins credentials to use for oracle terraform project.
blocked by the merge of the secrets from sops

Related to jenkins-infra/helpdesk#2973

@smerle33 smerle33 requested review from a team and dduportal June 8, 2022 13:02
config/ext_jenkins-infra-jobs.yaml Outdated Show resolved Hide resolved
dduportal
dduportal previously approved these changes Jun 8, 2022
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Suggestion from herve is not blocking but really a plus (Oracle is a trademark ©: better to write their name properly :D )
  • LGTM: code looks good, and the diff reports what is expected 👍

@dduportal
Copy link
Contributor

I let you @smerle33 merge once you've integrated the suggestion (if you feel like so)

@lemeurherve
Copy link
Member

  • Suggestion from herve is not blocking but really a plus (Oracle is a trademark ©: better to write their name properly :D )

There was also "staging" in prod items descritions ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants