Internationalization and localization improvements #6400

JE-Chen · 2023-05-24T02:12:14Z

#2642
#6363

Fix origin problem like link, grammar.

Add back .[adoc, images] Edit _chapter.yml

Refactor and Fix PR #2642 Problem

* Replace old name to new name Jenkins Development Support * Add image * Refactor doc

Update doc, old plugin option can't use now

Fix two same line to one line

MarkEWaite

Thanks so much for the pull request! I've made several proposed changes for your consideration. I haven't completed my review yet, but wanted to provide these initial comments so that you can continue the pull request and we can further improve it.

content/doc/developer/internationalization/internationalization-and-localization.adoc

Refactor the doc: Remove too old data. Hide NetBeans plugin intro. etc.

Replace broken link

gounthar

Thank you for your contribution.
Please feel free to make changes according to your preferences, including applying the one sentence per line rule.

content/doc/developer/internationalization/internationalization-and-localization.adoc

gounthar

Thank you for your contribution.
Please feel free to make changes according to your preferences, including applying the one sentence per line rule.

MarkEWaite

@JE-Chen thanks so much for the contributions.

I think that some of this content is covered in pages that already exist. I also think that this content would be better if we placed it on the top level page at http://www.jenkins.io/doc/developer/internationalization/ and marked that page as no longer being a "Work in progress".

Would it be OK with you if I submitted additional commits to this pull request in order to show what I mean by those ideas? If you find that you don't like the ideas, we can revert or delete my commits to the pull request

content/doc/developer/internationalization/internationalization-and-localization.adoc

MarkEWaite

@JE-Chen thanks so much for the contributions.

I think that some of this content is covered in pages that already exist. I also think that this content would be better if we placed it on the top level page at http://www.jenkins.io/doc/developer/internationalization/ and marked that page as no longer being a "Work in progress".

Would it be OK with you if I submitted additional commits to this pull request in order to show what I mean by those ideas? If you find that you don't like the ideas, we can revert or delete my commits to the pull request

They are closely related and belong together

@JE-Chen

Mark the internationalization and localization page as no longer being a work in progress. These changes make it complete enough. Still needs more work to bring additional content from @JE-Chen

MarkEWaite · 2023-05-24T20:45:54Z

@JE-Chen I submitted my ideas as additional commits in a draft pull request

Draft i18n page improvements #6405

If the general structure of those changes is acceptable to you, I'll bring more of your content from the proposed files into the new structure and submit them all on this branch.

You can view the preview of that proposal as:

https://deploy-preview-6405--jenkins-io-site-pr.netlify.app/doc/developer/internationalization/
https://deploy-preview-6405--jenkins-io-site-pr.netlify.app/doc/developer/internationalization/translate-a-properties-file/ (needs more content from your pull request)
https://deploy-preview-6405--jenkins-io-site-pr.netlify.app/doc/developer/internationalization/translate-a-help-file/ (needs more content that may not exist yet)

JE-Chen · 2023-05-25T01:07:28Z

@JE-Chen I submitted my ideas as additional commits in a draft pull request

Draft i18n page improvements #6405

If the general structure of those changes is acceptable to you, I'll bring more of your content from the proposed files into the new structure and submit them all on this branch.

You can view the preview of that proposal as:

https://deploy-preview-6405--jenkins-io-site-pr.netlify.app/doc/developer/internationalization/

https://deploy-preview-6405--jenkins-io-site-pr.netlify.app/doc/developer/internationalization/translate-a-properties-file/ (needs more content from your pull request)

https://deploy-preview-6405--jenkins-io-site-pr.netlify.app/doc/developer/internationalization/translate-a-help-file/ (needs more content that may not exist yet)

OK, Thanks.

Refactor one sentence per line rule. titles. link.

Replace : In this case, first you must write `+foo.properties+` for the default locale: with: In this case, first, you must write `+foo.properties+` for the default locale:

Replace: You can pass multiple parameters, separating them with ',' (just like a function call), and from property files you can reference them as \{0}, \{1}, etc., by following https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/text/MessageFormat.html[the with: You can pass multiple parameters, separating them with ',' (just like a function call), and from property files, you can reference them as \{0}, \{1}, etc., by following link:https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/text/MessageFormat.html[the MessageFormat class convention].

Refactor style.

Fix an format, I forgot change.

MarkEWaite

I've completed my changes. @JE-Chen does this look good enough to you?

JE-Chen · 2023-05-26T03:39:53Z

@MarkEWaite It's good to me. Thanks.

JE-Chen and others added 3 commits May 24, 2023 09:13

Add back PR #2642

f1317bb

Add back .[adoc, images] Edit _chapter.yml

Refactor and Fix PR #2642 Problem

19c6fbb

Refactor and Fix PR #2642 Problem

Merge branch 'jenkins-infra:master' into master

981363b

JE-Chen requested a review from a team as a code owner May 24, 2023 02:12

probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label May 24, 2023

infra-ci-jenkins-io bot deployed to preview May 24, 2023 02:22 View deployment

JE-Chen added 2 commits May 24, 2023 10:58

Update doc

a4cb61d

* Replace old name to new name Jenkins Development Support * Add image * Refactor doc

Merge branch 'master' of https://github.com/JE-Chen/jenkins.io_2642

f0f5627

infra-ci-jenkins-io bot deployed to preview May 24, 2023 03:06 View deployment

Update doc, old plugin option can't use now

37a6bd9

Update doc, old plugin option can't use now

infra-ci-jenkins-io bot deployed to preview May 24, 2023 03:23 View deployment

Update internationalization-and-localization.adoc

6caf16d

Fix two same line to one line

infra-ci-jenkins-io bot deployed to preview May 24, 2023 05:22 View deployment

MarkEWaite reviewed May 24, 2023

View reviewed changes

JE-Chen added 2 commits May 24, 2023 22:34

Refactor the doc

b2497ef

Refactor the doc: Remove too old data. Hide NetBeans plugin intro. etc.

Update internationalization-and-localization.adoc

afdf1b3

Replace broken link

infra-ci-jenkins-io bot deployed to preview May 24, 2023 15:21 View deployment

Merge branch 'master' into master

8a748bd

infra-ci-jenkins-io bot deployed to preview May 24, 2023 16:05 View deployment

gounthar approved these changes May 24, 2023

View reviewed changes

MarkEWaite changed the title ~~Refactor and fix PR #2642 problem~~ Internationalization and localization improvements May 24, 2023

MarkEWaite reviewed May 24, 2023

View reviewed changes

MarkEWaite added 5 commits May 24, 2023 12:37

Place setup a Crowdin project first in list

85287e4

Move Crowdin link immediately below internationalization

1a54f46

They are closely related and belong together

Add Crowdin video to plugin translation page

d37056c

Add Crowdin video and more text to Crowdin root page

5409e8f

Add translation how-to guides, link to them

09fbdce

Mark the internationalization and localization page as no longer being a work in progress. These changes make it complete enough. Still needs more work to bring additional content from @JE-Chen

MarkEWaite mentioned this pull request May 24, 2023

Draft i18n page improvements #6405

Closed

Refactor one sentence per line rule, titles, link.

7f4aa2d

Refactor one sentence per line rule. titles. link.

infra-ci-jenkins-io bot deployed to preview May 25, 2023 01:34 View deployment

JE-Chen added 2 commits May 25, 2023 09:41

Refactor

97c784f

Replace : In this case, first you must write `+foo.properties+` for the default locale: with: In this case, first, you must write `+foo.properties+` for the default locale:

infra-ci-jenkins-io bot deployed to preview May 25, 2023 01:48 View deployment

JE-Chen added 2 commits May 25, 2023 09:52

Refactor

5112920

Refactor style.

Update internationalization-and-localization.adoc

817c456

Fix an format, I forgot change.

infra-ci-jenkins-io bot deployed to preview May 25, 2023 02:01 View deployment

Merge branch 'master' into master

059bd21

infra-ci-jenkins-io bot deployed to preview May 25, 2023 08:54 View deployment

MarkEWaite and others added 4 commits May 25, 2023 11:41

Merge branch 'master' into mwaite-internationalization-changes

a62e551

Merge branch 'mwaite-internationalization-changes' into JE-Chen/master

506b805

Fix typo

e9fa4fe

Merge branch 'master' into master

6430a6e

infra-ci-jenkins-io bot deployed to preview May 26, 2023 01:30 View deployment

MarkEWaite added 2 commits May 25, 2023 19:53

Merge branch 'JE-Chen/master-bak' into JE-Chen/master

bc99cf6

First iteration of how-to guide

6aa14b4

infra-ci-jenkins-io bot deployed to preview May 26, 2023 03:07 View deployment

MarkEWaite approved these changes May 26, 2023

View reviewed changes

MarkEWaite mentioned this pull request May 26, 2023

Jenkins.io - Developer guide sorting chapters alphabetically #6375

Closed

NotMyFault approved these changes May 26, 2023

View reviewed changes

MarkEWaite merged commit 00546ec into jenkins-infra:master May 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internationalization and localization improvements #6400

Internationalization and localization improvements #6400

JE-Chen commented May 24, 2023 •

edited

Loading

MarkEWaite left a comment

gounthar left a comment

gounthar left a comment

MarkEWaite left a comment

MarkEWaite left a comment

MarkEWaite commented May 24, 2023 •

edited

Loading

JE-Chen commented May 25, 2023 •

edited

Loading

MarkEWaite left a comment

JE-Chen commented May 26, 2023 •

edited

Loading

Internationalization and localization improvements #6400

Internationalization and localization improvements #6400

Conversation

JE-Chen commented May 24, 2023 • edited Loading

MarkEWaite left a comment

Choose a reason for hiding this comment

gounthar left a comment

Choose a reason for hiding this comment

gounthar left a comment

Choose a reason for hiding this comment

MarkEWaite left a comment

Choose a reason for hiding this comment

MarkEWaite left a comment

Choose a reason for hiding this comment

MarkEWaite commented May 24, 2023 • edited Loading

JE-Chen commented May 25, 2023 • edited Loading

MarkEWaite left a comment

Choose a reason for hiding this comment

JE-Chen commented May 26, 2023 • edited Loading

JE-Chen commented May 24, 2023 •

edited

Loading

MarkEWaite commented May 24, 2023 •

edited

Loading

JE-Chen commented May 25, 2023 •

edited

Loading

JE-Chen commented May 26, 2023 •

edited

Loading