fix(check-chart-versions-bump): don't fail on new chart #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
force-pushed
the
fix-check-chart-version-bump
branch
4 times, most recently
from
dcdba63
to
0fe6c15
Compare
lemeurherve
added a commit
to lemeurherve/helm-charts
that referenced
this pull request
Aug 12, 2023
lemeurherve
added a commit
to lemeurherve/helm-charts
that referenced
this pull request
Aug 12, 2023
* feat: test only modified charts with unit tests on pull requests * run only on charts/** changes * small improvements replicated from jenkins-infra#598
lemeurherve
force-pushed
the
fix-check-chart-version-bump
branch
from
b2b4ad0
to
7b7009f
Compare
lemeurherve
changed the title
lemeurherve
force-pushed
the
fix-check-chart-version-bump
branch
from
7b7009f
to
7cb879c
Compare
dduportal
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
LGTM!
Same as #596 (review): not blocking (mostly nitpicking), but the value of using separated jobs is not clear to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
check-chart-versions-bumpGitHub Action workflow to not fail if the pull request adds a new chart (ie the correspondingcharts/<chart-name>/Chart.yamlfile doesn't exist in the target branch) or if the pull request Chart.yaml version isn't set.It also refactors the workflow to use a multi jobs mechanism similar to #596 and to run only if there are changes in
./charts/**.Tested on a fork.
Example with a new
anewchartchart and a change inaccountappchart for which the version hasn't been bumped: