Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill entry.author element with proper value when author name is unavailable #300

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pingu8007
Copy link

@pingu8007 pingu8007 commented Feb 17, 2020

This PR attempts to fix #299, where entry > author element will be filled with either of:

  • author.name.
  • author.twitter, prepend with @.
  • key string used to search in authors.yml, if neither name nor twitter is available.

If both name and twitter in author.yml unavailable, fallback to author key
@pingu8007 pingu8007 changed the title Fix issue 299 Fix #299 Feb 17, 2020
@ashmaroli
Copy link
Member

Hi @pingu8007 Could you update the title to something that best describes the patch? Thanks.
(One should not have to read an entire issue-ticket to get that info..)

@pingu8007 pingu8007 changed the title Fix #299 Fill entry.author element with proper value when author name unavailable (Fix #299) Feb 17, 2020
@ashmaroli ashmaroli changed the title Fill entry.author element with proper value when author name unavailable (Fix #299) Fill entry.author element with proper value when author name is unavailable Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author field returned in raw object
2 participants