fix: test & ci on 2x branch #2758
Conversation
Walkthrough本次变更引入了一个新的GitHub Actions工作流文件 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2758 +/- ##
=========================================
+ Coverage 0 84.07% +84.07%
=========================================
Files 0 217 +217
Lines 0 17831 +17831
Branches 0 2609 +2609
=========================================
+ Hits 0 14992 +14992
- Misses 0 2834 +2834
- Partials 0 5 +5 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
.github/workflows/add-label.yml (1)
28-33: 建议添加错误处理和文件结尾换行符
- 缺少对标签添加操作失败时的错误处理
- 文件末尾缺少换行符
建议修改为：
- name: Add label to Pull Request if: env.label != '' uses: actions-ecosystem/action-add-labels@v1 + continue-on-error: true with: github_token: ${{ secrets.GITHUB_TOKEN }} - labels: ${{ env.label }} + labels: ${{ env.label }} +🧰 Tools
🪛 yamllint
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/ci.yml (1)
84-84: 建议：添加文件末尾的换行符根据 POSIX 标准，每个文本文件都应该以换行符结束。
if: github.ref == 'refs/heads/next' - run: npm run build:taro:site + run: npm run build:taro:site +🧰 Tools
🪛 yamllint
[error] 84-84: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
src/packages/range/__test__/__snapshots__/range.spec.tsx.snapis excluded by!**/*.snapsrc/packages/textarea/__test__/__snapshots__/textarea.spec.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (2)
.github/workflows/add-label.yml(1 hunks).github/workflows/ci.yml(2 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/add-label.yml
18-18: shellcheck reported issue in this script: SC2086:info:3:23: Double quote to prevent globbing and word splitting
(shellcheck)
18-18: shellcheck reported issue in this script: SC2086:info:5:23: Double quote to prevent globbing and word splitting
(shellcheck)
18-18: shellcheck reported issue in this script: SC2086:info:7:20: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint
.github/workflows/add-label.yml
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/ci.yml
[error] 84-84: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/add-label.yml (1)
1-33: 验证工作流程的完整性
需要验证此工作流是否正确集成到现有的 CI/CD 流程中。
✅ Verification successful
工作流程集成验证完成
工作流程已正确集成，原因如下：
-
标签操作没有冲突：仅在
add-label.yml中使用action-add-labels进行 PR 标签管理，其他工作流中的标签操作（如issue-reply.yml和issue-close.yml）都是针对 issues 的不同场景。 -
触发器设置合理：
add-label.yml使用pull_request_target是独特的，没有与其他工作流冲突- 其他工作流使用不同的触发器（如
push、schedule、issues），各司其职
-
完整性良好：工作流职责划分清晰，
add-label.yml专注于 PR 分支标签管理，与其他 CI/CD 工作流（如ci.yml、sync-*.yml）形成互补。
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 检查其他工作流程文件中是否存在重复的标签操作
# 搜索其他工作流程文件中的标签相关操作
echo "检查其他工作流程文件中的标签操作..."
rg -l "action-add-labels" .github/workflows/ | grep -v "add-label.yml"
# 检查是否有其他工作流使用相同的触发器
echo "检查触发器重复..."
rg "pull_request_target" .github/workflows/ | grep -v "add-label.yml"
Length of output: 471
Script:
#!/bin/bash
# 检查工作流程文件的完整性
# 列出所有工作流程文件
echo "所有工作流程文件："
fd -e yml -e yaml . .github/workflows/
# 检查是否有其他标签相关的操作
echo -e "\n查找标签相关操作："
rg -i "labels?" .github/workflows/ -A 2 -B 2
# 检查所有工作流程的触发器
echo -e "\n所有工作流程的触发器："
rg "^on:" .github/workflows/ -A 5
Length of output: 5681
🧰 Tools
🪛 actionlint
18-18: shellcheck reported issue in this script: SC2086:info:3:23: Double quote to prevent globbing and word splitting
(shellcheck)
18-18: shellcheck reported issue in this script: SC2086:info:5:23: Double quote to prevent globbing and word splitting
(shellcheck)
18-18: shellcheck reported issue in this script: SC2086:info:7:20: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/ci.yml (2)
8-8: 从 pull_request_target 切换到 pull_request 事件是一个很好的安全改进！
这个改动提高了工作流的安全性，因为 pull_request 事件在隔离的环境中运行，不会暴露仓库的敏感信息。
83-84: 验证 Taro H5 演示构建的条件执行
构建步骤的条件限制看起来合理，但建议验证这个改动不会影响其他分支的部署需求。
✅ Verification successful
Taro H5 演示构建条件验证已完成
经过验证，当前的构建配置是合理的：
build:taro:site脚本仅在next分支的工作流中被调用- 其他分支（如
V3.0）的工作流中没有使用此构建步骤 - 这个条件限制不会影响其他分支的部署需求
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 描述：验证其他分支是否需要构建 Taro H5 演示
# 检查其他分支的部署配置
rg -l "build:taro:site" --type yaml
Length of output: 35
Script:
#!/bin/bash
# 检查 package.json 中的 build:taro:site 脚本定义
cat package.json | jq -r '.scripts["build:taro:site"]'
# 检查所有工作流文件中的构建步骤
fd -e yml -e yaml . .github/workflows/ --exec cat {}
Length of output: 7948
🧰 Tools
🪛 yamllint
[error] 84-84: no new line character at the end of file
(new-line-at-end-of-file)
| - name: Determine label based on target branch | ||
| id: determine-label | ||
| run: | | ||
| echo "${{github.event_name}}" | ||
| if [[ "${{ github.event.pull_request.base.ref }}" == "next" ]]; then | ||
| echo "label=2.x" >> $GITHUB_ENV | ||
| elif [[ "${{ github.event.pull_request.base.ref }}" == "V3.0" ]]; then | ||
| echo "label=3.x" >> $GITHUB_ENV | ||
| else | ||
| echo "label=" >> $GITHUB_ENV | ||
| fi |
There was a problem hiding this comment.
🛠️ Refactor suggestion
优化标签判断逻辑的实现
当前实现存在以下问题：
- 缺少对
github.event.pull_request是否存在的检查 - shell 脚本中的变量引用没有使用双引号
- 调试信息
echo "${{github.event_name}}"应该移除
建议修改为：
- name: Determine label based on target branch
id: determine-label
run: |
- echo "${{github.event_name}}"
+ if [[ "${{ github.event_name }}" == "pull_request_target" && -n "${{ github.event.pull_request.base.ref }}" ]]; then
if [[ "${{ github.event.pull_request.base.ref }}" == "next" ]]; then
echo "label=2.x" >> "$GITHUB_ENV"
elif [[ "${{ github.event.pull_request.base.ref }}" == "V3.0" ]]; then
echo "label=3.x" >> "$GITHUB_ENV"
else
echo "label=" >> "$GITHUB_ENV"
fi
+ else
+ echo "label=" >> "$GITHUB_ENV"
+ fi📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Determine label based on target branch | |
| id: determine-label | |
| run: | | |
| echo "${{github.event_name}}" | |
| if [[ "${{ github.event.pull_request.base.ref }}" == "next" ]]; then | |
| echo "label=2.x" >> $GITHUB_ENV | |
| elif [[ "${{ github.event.pull_request.base.ref }}" == "V3.0" ]]; then | |
| echo "label=3.x" >> $GITHUB_ENV | |
| else | |
| echo "label=" >> $GITHUB_ENV | |
| fi | |
| - name: Determine label based on target branch | |
| id: determine-label | |
| run: | | |
| if [[ "${{ github.event_name }}" == "pull_request_target" && -n "${{ github.event.pull_request.base.ref }}" ]]; then | |
| if [[ "${{ github.event.pull_request.base.ref }}" == "next" ]]; then | |
| echo "label=2.x" >> "$GITHUB_ENV" | |
| elif [[ "${{ github.event.pull_request.base.ref }}" == "V3.0" ]]; then | |
| echo "label=3.x" >> "$GITHUB_ENV" | |
| else | |
| echo "label=" >> "$GITHUB_ENV" | |
| fi | |
| else | |
| echo "label=" >> "$GITHUB_ENV" | |
| fi |
🧰 Tools
🪛 actionlint
18-18: shellcheck reported issue in this script: SC2086:info:3:23: Double quote to prevent globbing and word splitting
(shellcheck)
18-18: shellcheck reported issue in this script: SC2086:info:5:23: Double quote to prevent globbing and word splitting
(shellcheck)
18-18: shellcheck reported issue in this script: SC2086:info:7:20: Double quote to prevent globbing and word splitting
(shellcheck)
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
add-label.yml，用于根据拉取请求的目标分支自动添加标签。pull_request_target更改为pull_request。add-label作业，简化了 CI 流程。next时构建。