Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: harmonyOS supports global stylesheets #2751

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

oasis-cloud
Copy link
Collaborator

@oasis-cloud oasis-cloud commented Nov 14, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新特性

    • 移除了对 SCSS 注入的插件,简化了插件配置。
  • 变更

    • 更新了编译器配置,去掉了与 SCSS 相关的设置。

Copy link

coderabbitai bot commented Nov 14, 2024

Walkthrough

本次变更主要涉及 packages/nutui-taro-demo/config/index.js 文件和 packages/nutui-taro-demo/plugins/inject-scss.js 文件的修改。index.js 文件中,injectScss 插件从 plugins 数组中移除,并且 compiler 配置中的 vitePlugins 数组也被简化,保留了 type 设置为 vite。同时,inject-scss.js 文件被删除,该文件原本用于在构建过程中注入 SCSS。此次变更简化了插件配置,但未引入新的错误处理或控制流机制。

Changes

文件路径 变更摘要
packages/nutui-taro-demo/config/index.js 移除 injectScss 插件,简化 plugins 数组配置;更新 compiler 配置,移除 vitePlugins 数组。
packages/nutui-taro-demo/plugins/inject-scss.js 删除文件,移除 injectScss() 函数。

Possibly related PRs

Suggested labels

size/XL, 3.x

兔子欢跳庆新变,
插件简化真轻便。
SCSS不再入构建,
配置清晰更明亮。
兔子乐舞在田间,
代码简洁心欢畅。 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 47afee6 and a25a3d5.

📒 Files selected for processing (2)
  • packages/nutui-taro-demo/config/index.js (2 hunks)
  • packages/nutui-taro-demo/plugins/inject-scss.js (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/nutui-taro-demo/plugins/inject-scss.js
🔇 Additional comments (2)
packages/nutui-taro-demo/config/index.js (2)

131-131: 验证 Vite 编译配置的完整性

编译器配置已简化为仅使用 Vite。建议确认以下几点:

  1. HarmonyOS 的全局样式是否能被正确编译
  2. 是否需要额外的 Vite 插件来处理特定的样式需求

建议在文档中补充说明 HarmonyOS 环境下的样式处理机制,以便其他开发者理解和维护。


73-73: 确认样式注入的替代方案

移除了 injectScss 插件配置,请确认在 HarmonyOS 环境下的全局样式注入是否已经由平台层面进行处理。

✅ Verification successful

Based on the search results, I can see that the HarmonyOS stylesheet handling has been implemented through a different approach:

  1. The gulpfile.js shows compilation of .scss files to .harmony.css files
  2. In packages/nutui-taro-demo/config/index.js, there's a platform-specific plugin '@dongdesign/inject-jd-platform-styles' being used
  3. The demo generation scripts show proper importing of .harmony.css files

Let me generate the final response:

样式注入已通过平台插件实现

移除 injectScss 插件是合理的,因为:

  • HarmonyOS 环境下的样式注入已通过 @dongdesign/inject-jd-platform-styles 插件处理
  • 组件样式已被预编译为 .harmony.css 文件并正确导入
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 检查是否存在其他样式注入相关的配置或插件
rg -i "scss|style|css" --type js

Length of output: 17041


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (47afee6) to head (a25a3d5).
Report is 2 commits behind head on V3.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             V3.0    #2751   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         221      221           
  Lines       17878    17878           
  Branches     2676     2676           
=======================================
  Hits        15016    15016           
  Misses       2857     2857           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irisSong irisSong merged commit e576eee into jdf2e:V3.0 Nov 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants