Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 提取 Taro 的 Demo 到 workspace #1302

Merged
merged 6 commits into from
Aug 14, 2023
Merged

feat: 提取 Taro 的 Demo 到 workspace #1302

merged 6 commits into from
Aug 14, 2023

Conversation

oasis-cloud
Copy link
Collaborator

🤔 这个变动的性质是?

  • 站点、文档改进
  • 演示代码改进

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

@oasis-cloud oasis-cloud requested a review from eiinu August 10, 2023 10:37
@eiinu
Copy link
Member

eiinu commented Aug 11, 2023

packages/nutui-taro-demo/package.json 中的 resolutions 需要调整到项目根目录的 package.json 中,放在子包中是无效的。比如现在的 lock 文件中 @swc/core 的版本就不是设定的值。

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1302 (d40d13a) into next (c7fa080) will not change coverage.
Report is 2 commits behind head on next.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1302   +/-   ##
=======================================
  Coverage   70.78%   70.78%           
=======================================
  Files         200      200           
  Lines        7907     7907           
  Branches     2270     2270           
=======================================
  Hits         5597     5597           
  Misses       2105     2105           
  Partials      205      205           

@eiinu
Copy link
Member

eiinu commented Aug 11, 2023

build:weapp 时会报错
image

@oasis-cloud oasis-cloud merged commit fcc3a8e into jdf2e:next Aug 14, 2023
5 checks passed
@oasis-cloud oasis-cloud deleted the pnpm-wk branch August 28, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants