Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPENJDK-2993] re-tag jolokia Feature #486

Merged
merged 2 commits into from
Apr 28, 2024
Merged

[OPENJDK-2993] re-tag jolokia Feature #486

merged 2 commits into from
Apr 28, 2024

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented Apr 25, 2024

Ensure the first of the three Scenarios is covered by tags.

https://issues.redhat.com/browse/OPENJDK-2993

@jmtd
[OPENJDK-2993] re-tag jolokia Feature
9baeab7 
Ensure the first of the three Scenarios is covered by tags.

https://issues.redhat.com/browse/OPENJDK-2993

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd requested a review from jhuttana April 25, 2024 11:15
@jhuttana
Copy link
Contributor

jhuttana commented Apr 26, 2024 •
edited
Loading

I tried to run jolokia.feature with the changes in this PR and below are the results

JDK-11
$ cekit --descriptor ubi8-openjdk-11.yaml test --image ubi8/openjdk-11 behave --include-re jolokia
.
.
.
Failing scenarios:
  features/jboss.container.jolokia/jolokia.feature:6  Check Environment variable is correct

0 features passed, 1 failed, 0 skipped
2 scenarios passed, 1 failed, 0 skipped
7 steps passed, 1 failed, 0 skipped, 0 undefined
Took 10m30.844s

#######################################################################################################
JDK-8
$ cekit --descriptor ubi8-openjdk-8.yaml test --image ubi8/openjdk-8 behave --include-re jolokia
.
.
.
Failing scenarios:
  features/jboss.container.jolokia/jolokia.feature:6  Check Environment variable is correct

0 features passed, 1 failed, 0 skipped
2 scenarios passed, 1 failed, 0 skipped
7 steps passed, 1 failed, 0 skipped, 0 undefined
Took 10m29.177s

If this is a expected failure then the PR looks good to me.
As per this PR #458 it looks like the test will pass on GHA.

@jmtd
[OPENJDK-2993] Fix jolokia test that used 'unzip'
cea1714 
We dropped unzip from the images as nothing else was using it. Rework
the jolokia test that used unzip to use jar instead.  Adjust the test
to not require s2i so it executes much faster and retitle it to be
clearer as to what it is testing.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd
Copy link
Member Author

jmtd commented Apr 26, 2024

@jhuttana

If this is a expected failure

Good catch: It is not, but I didn't test it after re-tagging it. I've fixed the test and pushed another commit. If you have time to verify it, that would be great!

@jhuttana
Copy link
Contributor

@jhuttana

If this is a expected failure

Good catch: It is not, but I didn't test it after re-tagging it. I've fixed the test and pushed another commit. If you have time to verify it, that would be great!

I checked it locally and the test is passing with recent commit

$ cekit --descriptor ubi8-openjdk-8.yaml test --image ubi8/openjdk-8 behave --name 'Ensure JOLOKIA_VERSION variable aligns with JAR'
.
.
.
1 feature passed, 0 failed, 16 skipped
1 scenario passed, 0 failed, 91 skipped
2 steps passed, 0 failed, 264 skipped, 0 undefined
Took 0m11.019s
2024-04-28 13:58:12,498 cli.py:531        INFO  Finished!

@jmtd jmtd merged commit e4b427f into jboss-container-images:ubi8 Apr 28, 2024
0 of 8 checks passed
@jmtd jmtd deleted the retag-jolokia-tests branch April 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuttana jhuttana jhuttana approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmtd @jhuttana