Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session id logic #293

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Update session id logic #293

merged 1 commit into from
Oct 12, 2024

Conversation

jborean93
Copy link
Owner

@jborean93 jborean93 commented Oct 11, 2024

Updates the session id lookup logic to comply with the MS-SMB2 spec.

Fixes: #289

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (2bed7bc) to head (3612fb0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   99.04%   99.06%   +0.01%     
==========================================
  Files          24       24              
  Lines        5116     5117       +1     
==========================================
+ Hits         5067     5069       +2     
+ Misses         49       48       -1     
Flag Coverage Δ
macOS 68.18% <33.33%> (+<0.01%) ⬆️
py3.10 99.02% <100.00%> (+0.01%) ⬆️
py3.11 99.02% <100.00%> (+0.01%) ⬆️
py3.12 99.02% <100.00%> (+0.01%) ⬆️
py3.8 99.02% <100.00%> (+0.01%) ⬆️
py3.9 99.06% <100.00%> (+0.01%) ⬆️
ubuntu 96.83% <100.00%> (+0.02%) ⬆️
windows 98.98% <100.00%> (+0.01%) ⬆️
x64 99.06% <100.00%> (+0.01%) ⬆️
x86 98.98% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Updates the session id lookup logic to comply with the MS-SMB2 spec.
@jborean93 jborean93 changed the title Update session id logic and file stand info parsing Update session id logic Oct 12, 2024
@jborean93 jborean93 merged commit 42804ca into master Oct 12, 2024
22 checks passed
@jborean93 jborean93 deleted the impacket2 branch October 12, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble connecting with username and password
1 participant