Fix Impacket logoff session id check #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the session lookup logic when the logoff response contains a session id of 0. This occurs when using an Impacket server and will have the client just lookup the session id from the request. Also adjusts the connection cache clearing behaviour to remove the connection from the cache regardless of the result of the disconnect behaviour.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 24 24
Lines 5116 5116
=======================================
Hits 5067 5067
Misses 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the session lookup logic when the logoff response contains a session id of 0. This occurs when using an Impacket server and will have the client just lookup the session id from the request.
Also adjusts the connection cache clearing behaviour to remove the connection from the cache regardless of the result of the disconnect behaviour.
Fixes: #289