-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type information of SMBDirEntryInformation.last_write_time set to datetime #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
We need Jordan for the final approval and merge.
How have you discovered this issue ?
Would it be possible, as part of this PR, to add a brief mypy
call as part of the GitHub Actions checks, so that we make sure no regression will be introduced in the future ?
Just asking. :)
Co-authored-by: Adi Roiban <[email protected]>
I found it "visually" when working in intellij. ;) No idea how to do the mypy stuff. Sorry for that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 24 24
Lines 5115 5115
=======================================
Hits 5066 5066
Misses 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing up this annotation, looks like it was an issue that was missed in the review when it was added.
Looks like I need to update CI now that macOS-latest is using the new arm runners. The failures there are unrelated to your changes so I'll merge this in. Appreciate you fixing this up! |
Fixed issue #279