type information of SMBDirEntryInformation.last_write_time set to datetime

[christianknoepfle]

Fixed issue #279

[adiroiban]

Thanks for the PR.

We need Jordan for the final approval and merge.

How have you discovered this issue ?

Would it be possible, as part of this PR, to add a brief mypy call as part of the GitHub Actions checks, so that we make sure no regression will be introduced in the future ?

Just asking. :)

[christianknoepfle]

I found it "visually" when working in intellij. ;) No idea how to do the mypy stuff. Sorry for that

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (3f69e6d) to head (3bb760c).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          24       24           
  Lines        5115     5115           
=======================================
  Hits         5066     5066           
  Misses         49       49           

Flag	Coverage Δ
macOS	?
py3.10	99.00% <100.00%> (ø)
py3.11	99.00% <100.00%> (ø)
py3.12	99.00% <100.00%> (ø)
py3.8	99.00% <100.00%> (ø)
py3.9	99.04% <100.00%> (ø)
ubuntu	96.81% <100.00%> (ø)
windows	98.96% <100.00%> (ø)
x64	99.04% <100.00%> (ø)
x86	98.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jborean93]

Thanks for fixing up this annotation, looks like it was an issue that was missed in the review when it was added.

[jborean93]

Looks like I need to update CI now that macOS-latest is using the new arm runners. The failures there are unrelated to your changes so I'll merge this in.

Appreciate you fixing this up!