Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show low-level OS error on TCP connection errors. #264

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

adiroiban
Copy link
Contributor

Scope

Fixes #259

Changes

Apply the same format that was used in older version and update the existing automated test.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d6abeb) 99.06% compared to head (59dd30e) 99.06%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          24       24           
  Lines        5112     5112           
=======================================
  Hits         5064     5064           
  Misses         48       48           
Flag Coverage Δ
99.06% <100.00%> (ø)
py3.10 99.02% <100.00%> (ø)
py3.11 99.02% <100.00%> (ø)
py3.12 99.02% <100.00%> (ø)
py3.7 99.01% <100.00%> (ø)
py3.8 99.02% <100.00%> (ø)
py3.9 99.05% <100.00%> (ø)
x64 99.06% <100.00%> (ø)
x86 98.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adiroiban
Copy link
Contributor Author

This should be ready for review. Thanks

@jborean93
Copy link
Owner

Thanks for fixing this up!

@jborean93 jborean93 merged commit 2cfd6b5 into jborean93:master Jan 27, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smbprotocol.connection.Connection.connect() no longer shows the low-level connection error
2 participants