Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_option attribute #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add get_option attribute #82

wants to merge 2 commits into from

Commits on Feb 2, 2022

  1. Add get_option attribute 

    Getters that return `&Option<T>` instead of `Option<&T>` can lead to boilerplate code, as they require the user to pollute code with `.as_ref()`.
    @hochej
    hochej committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b261065 View commit details
    Browse the repository at this point in the history

  2. Fix wrong behaviour of get_option for normal fields 

    Previously, even in cases where a field did not have a get_option
attribute, an attempt was made to determine the inner type of the
option. This has erroneously led to errors.
The change now ensures that the implement function is returnes
beforehand.
    @hochej
    hochej committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5258bb7 View commit details
    Browse the repository at this point in the history