Add optional requirement specifier "html" back #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 28 28
Lines 2958 2958
=======================================
Hits 2741 2741
Misses 217 217 ☔ View full report in Codecov by Sentry. |
hugovk
approved these changes
Apr 3, 2024
|
Please could you also add this as a bugfix in https://github.com/jazzband/tablib/blob/master/HISTORY.md in this PR, with 3.6.1 and today's date, and I'll make a new release? |
Removing such a specifier should be considered a breaking change and be postponed to the next major release, because `pip install tablib[html]` fails on this. Since there are no actual dependencies to consider, an empty list is put behind that key. fixes jazzband#588
mdellweg
force-pushed
the
fix_optional_dependency
branch
from
802795d
to
e8994fa
Compare
|
Thanks! |
|
Thanks, this has been released: https://pypi.org/project/tablib/3.6.1/ |
|
Thank you so much for pushing it through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing such a specifier should be considered a breaking change and be postponed to the next major release, because
pip install tablib[html]fails on this. Since there are no actual dependencies to consider, an empty list is put behind that key.fixes #588