Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versionchanged/added directives from before 1.0 #575

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Dec 20, 2023

No description provided.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01ac5e6) 92.46% compared to head (b503ad2) 92.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files          28       28           
  Lines        2961     2961           
=======================================
  Hits         2738     2738           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk
Copy link
Member

hugovk commented Dec 21, 2023

I looked up some numbers, about 5% are still using a 0.x version!

image

@claudep
Copy link
Contributor Author

claudep commented Dec 21, 2023

We can pause this PR if you like, however the most recent deleted directive, 0.9.5, was released on March 2011!

@hugovk
Copy link
Member

hugovk commented Dec 21, 2023

That's quite a while ago! I'm guessing systems with such old versions aren't in a rush to upgrade the new features!

Feel free to merge once the conflict is resolved.

@claudep claudep merged commit 23b84ed into jazzband:master Dec 21, 2023
21 checks passed
@claudep claudep deleted the remove_old_changes branch December 21, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants