Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release #402

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Prepare for release #402

merged 2 commits into from
Oct 19, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 18, 2019

For #400.

Will fill in the date in on release day.

@hugovk hugovk mentioned this pull request Oct 18, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #402   +/-   ##
======================================
  Coverage    79.1%   79.1%           
======================================
  Files          30      30           
  Lines        2269    2269           
======================================
  Hits         1795    1795           
  Misses        474     474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1aa3a...a40852d. Read the comment docs.

claudep
claudep approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! As for me, I think we are ready to go.

@hugovk hugovk merged commit 0e022d8 into jazzband:master Oct 19, 2019
@claudep
Copy link
Contributor

claudep commented Oct 19, 2019

🎆

@hugovk hugovk deleted the release-prep branch October 19, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @claudep