Replace deepcopy of the Q object #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still trying to run unit tests locally, hoping marking this PR as ready would trigger some on project side. |
|
See #542 |
rrauenza
changed the title
rrauenza
changed the title
rrauenza
force-pushed
the
patch0
branch
6 times, most recently
from
6616348
to
ebf9c4d
Compare
|
Can also confirm that is indeed fixing the issue in deepcopying Q objects. (reproduced on Python 3.7) |
|
Is there some unittest can cover the case it fixes? |
|
I think if the existing unit tests work, that is sufficient, since it shows the change doesn't break from the current method of copying. We could assign a non picklable object attr to one of the children to prevent future regression? |
j-antunes
added a commit
to j-antunes/django-polymorphic
that referenced
this pull request
Nov 14, 2023
|
+1 to adding a non picklable object attr to prevent future regressions or even an explicit scenario that should break in 3.7 without this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.