Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Feed support #975

Merged
merged 15 commits into from
Aug 6, 2023
Merged

Add JSON Feed support #975

merged 15 commits into from
Aug 6, 2023

Conversation

ozkutuk
Copy link
Contributor

@ozkutuk ozkutuk commented Mar 24, 2023

The JSON Feed format is a pragmatic syndication format, like RSS and Atom, but with one big difference: it’s JSON instead of XML.

This PR adds JSON Feed support to Hakyll with a pretty barebone template, conforming to the JSON Feed 1.1 spec. I have deployed it to my personal blog to serve as a working example, and it seems to work without any issues.

Copy link
Collaborator

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks excellent! I left a few nitpicks in comments below, please take a look.

lib/Hakyll/Web/Feed.hs Show resolved Hide resolved
lib/Hakyll/Web/Feed.hs Outdated Show resolved Hide resolved
lib/Hakyll/Web/Feed.hs Outdated Show resolved Hide resolved
data/templates/feed-item.json Show resolved Hide resolved
@ozkutuk ozkutuk requested a review from Minoru May 21, 2023 19:02
Copy link
Collaborator

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once the CI is done.

Thank you for the work, @ozkutuk, and for putting up with such delays in reviewing this!

@Minoru Minoru merged commit 858af2d into jaspervdj:master Aug 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants