-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON Feed support #975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks excellent! I left a few nitpicks in comments below, please take a look.
- Make function names consistent with the rest - Model string escaping logic according to RFC8259
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once the CI is done.
Thank you for the work, @ozkutuk, and for putting up with such delays in reviewing this!
This PR adds JSON Feed support to Hakyll with a pretty barebone template, conforming to the JSON Feed 1.1 spec. I have deployed it to my personal blog to serve as a working example, and it seems to work without any issues.