Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace footer with microbutton #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Minoru
Copy link
Collaborator

@Minoru Minoru commented Nov 17, 2020

I'm actually not that convinced anymore that this is useful, but if you like it, @jaspervdj, here you go — this is the reincarnation of #367 :)

@jaspervdj
Copy link
Owner

Sorry, I'm being a bit indecisive about this. I like the button but I feel like most users appreciate plain text, which is also easier to style. Let's keep this open and if nobody really wants this we'll close it again.

@zjp
Copy link

zjp commented Mar 22, 2021

This sounds like an excellent thing to put in a /contrib folder

@Minoru
Copy link
Collaborator Author

Minoru commented Mar 26, 2021

@zjp Perhaps! But Hakyll doesn't have one, and I'm not interested enough to go make one and add mentions to all the docs. Feel free to submit a different PR if you wish :P

@lierdakil
Copy link
Contributor

lierdakil commented Mar 28, 2021

most users appreciate plain text

I'm certainly not "most users", but I kinda prefer the "button". It'll look right at home with the licence "button" (e.g. image) etc that also live in my footers.

I obviously have no strong preference one way or the other since it's trivial to change, but having a "button" be the default seems more flexible, i.e. it's easier to replace a button with text than vice versa.

@zjp
Copy link

zjp commented Mar 29, 2021

@zjp Perhaps! But Hakyll doesn't have one, and I'm not interested enough to go make one and add mentions to all the docs. Feel free to submit a different PR if you wish :P

I will! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants