remove weigthing options and rename to consistent PLS #204
Conversation
R/plssem.R
Outdated
| sink(file="~/Downloads/log.txt") | ||
| on.exit(sink(NULL)) |
|
stupid of me. But to be honest, this is not yet really ready, adding the construct scores has been a bit of a mystery of constant recalculations, and I need to solve that first. Let me convert to draft to make it clear. Sorry about that |
|
@juliuspfadt Hey Julius, in case you have questions about the calculation of the construct scores in PLS, we can also have a brief meeting... |
juliuspfadt
force-pushed
the
cPLSfix
branch
3 times, most recently
from
e5e944b
to
d2fbeaa
Compare
|
Thanks :) But the issue is not getting the scores, but how they are added to the data set. So far, adding the columns to the data results in recalculation of the analysis, re-adding the columns, recalculation, .... infinity. :D |
Related to PR jasp-stats/jaspSem#204 A new function adds the scores to the dataset: this restarts the SEM analysis endlessly.
Related to PR jasp-stats/jaspSem#204 A new function adds the scores to the dataset: this restarts the SEM analysis endlessly.
|
So brunos fix is in, a new nightly will be build soon enough that should stop the restarting |
|
Thats great news!!! Thanks. |
juliuspfadt
requested review from
Kucharssim
and removed request for
Kucharssim
juliuspfadt
force-pushed
the
cPLSfix
branch
from
9ea2b58
to
5815d06
Compare
|
@Kucharssim, should I ask someone else to review? |
|
@FloSchuberth any chance you have some spare time to test this? If you have, and need help installing the module, let me know :) |
|
Hey @julius ***@***.***>
Yes, I can have look.
And yes, a quick refresh would be nice.
What I have done so far:
I have created a fork of your branch: https://github.com/jasp-stats/jaspSem/tree/master
Then I used Rstudio to create a local copy of that fork: File->New project->Version control-> Git using my repository url: https://github.com/FloSchuberth/jaspSem
I have installed JASP version 19.01. I started it -> Preferences -> Advanced
There I checked Developer mode and have selected the local jaspSEM folder.
If I click on Install Module, I get an error, see file attached. Any ideas?
If it helps we can also schedule a brief meeting for next week.
Best regards,
Flo
From: Julius Pfadt ***@***.***>
Sent: dinsdag 1 oktober 2024 10:38
To: jasp-stats/jaspSem ***@***.***>
Cc: Schuberth, Florian (UT-ET) ***@***.***>; Mention ***@***.***>
Subject: Re: [jasp-stats/jaspSem] remove weigthing options and rename to consistent PLS (PR #204)
@FloSchuberth<https://github.com/FloSchuberth> any chance you have some spare time to test this? If you have, and need help installing the module, let me know :)
-
Reply to this email directly, view it on GitHub<#204 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD5KRRBVQYAC7WRDWPFFLNTZZJNPFAVCNFSM6AAAAABC5MKN5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBVGE2DGNJQHA>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
|
I checked things with @FloSchuberth (expert from U-Twente) regarding the functionality, maybe someone can do a quick code check? @vandenman, or @FBartos? |
|
Thanks :) |
fixes jasp-stats/jasp-issues#2356
fixes jasp-stats/jasp-issues#2265
Suggestions of @FloSchuberth: