fix screeplot

jasp-stats · Oct 30, 2024 · 3886b03 · 3886b03
1 parent 1cd9f00
commit 3886b03
Show file tree

Hide file tree

Showing 3 changed files with 953 additions and 393 deletions.
diff --git a/R/exploratoryfactoranalysis.R b/R/exploratoryfactoranalysis.R
@@ -734,9 +734,14 @@ exploratoryFactorAnalysisInternal <- function(jaspResults, dataset, options, ...
     plt <- plt + ggplot2::geom_point(na.rm = TRUE, size = max(0, 3 + log(10) - log(n_col)))
   }
 
-  # theming with special legend thingy
+  # add axis lines and better breaks
   plt <- plt +
+    jaspGraphs::geom_rangeframe() +
     jaspGraphs::themeJaspRaw() +
+    ggplot2::scale_x_continuous(breaks = seq(1:n_col))
+
+  # theming with special legend thingy
+  plt <- plt +
     ggplot2::theme(
       legend.position      = c(0.99, 0.95),
       legend.justification = c(1, 1),

diff --git a/R/principalcomponentanalysis.R b/R/principalcomponentanalysis.R
@@ -532,6 +532,12 @@ principalComponentAnalysisInternal <- function(jaspResults, dataset, options, ..
     plt <- plt + ggplot2::geom_point(na.rm = TRUE, size = max(0, 3 + log(10) - log(n_col)))
   }
 
+  # add axis lines and better breaks
+  plt <- plt +
+    jaspGraphs::geom_rangeframe() +
+    jaspGraphs::themeJaspRaw() +
+    ggplot2::scale_x_continuous(breaks = seq(1:n_col))
+
   # theming with special legend thingy
   plt <- plt +
     jaspGraphs::themeJaspRaw() +