Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes dependencies and lower bounded Bayesian tests with -Inf prior #127

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FBartos
Copy link

@FBartos FBartos commented Oct 30, 2024

Fixes: jasp-stats/jasp-issues#2984

The issue was a result of two problems:

  • incorrect dependencies to the prior component (the prior was updated only when the bounds changed
  • the normal integration produced faulty results when lower bound = -Inf

This PR:

  • Unifies dependencies across the analyses (and makes them easier to maintain via common global variables)
  • Skips numerical integration for normal priors if the bound is equal to Inf

@FBartos
Copy link
Author

FBartos commented Oct 30, 2024

I also added the GroupTitles with the corresponding logos:
image

@FBartos
Copy link
Author

FBartos commented Oct 30, 2024

(the unit tests seem to be failing for quite some time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bayesian equivalence test with Normal prior fails if interval starts with minus infinity
1 participant