Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .msi installer: only current user can disable MS-GameDVR #5639

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Aug 22, 2024

Address issue: jasp-stats/jasp-issues#2841

People don't always have admin privileges, so let's take this action only for the current user.

Also capitalized all GUIDs, this is required by Microsoft MSI see: https://learn.microsoft.com/en-us/windows/win32/msi/guid

Can merge to another branch and make a test build let users test it.

@RensDofferhoff
Copy link
Contributor

I will make a build to test now. Thanks!

@shun2wang
Copy link
Contributor Author

@boutinb @RensDofferhoff so what should we do for this .msi installer as we will release hotfix soon.

@shun2wang
Copy link
Contributor Author

I also want to migrate .msi installer to .exe installer with NSIS tools someday. any ideas?

@boutinb
Copy link
Contributor

boutinb commented Sep 9, 2024

@boutinb @RensDofferhoff so what should we do for this .msi installer as we will release hotfix soon.

We want to make a hotfix (0.19.1) with just the filter issue fix, so that we can deliver it with minimal testing. We should do that today.
We want also to make a new version (0.19.2) in October, so that the other fixes (and new features) can be released quite quickly. This version will need more testing.

@shun2wang
Copy link
Contributor Author

But installer related problems is more critically I think.just a suggestion.

@RensDofferhoff
Copy link
Contributor

Last Time I made a build I remember there was a problem still on my machine. I will need to recheck this.
0.19.2 will follow 0.19.1 shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants