Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning for unsupported file types #124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mazunki
Copy link

@mazunki mazunki commented Dec 31, 2021

  • removed warning about used exception var
  • added warning about incompatible filetype extensions
  • commented unused variables from legacy commented code, thus removing warnings

@mazunki
Copy link
Author

mazunki commented Dec 31, 2021

I was struggling to export an NBT file to JSON through the NBTUtil. After digging into the code I realized there was a hardcoded regex patterns to match filetypes. I added a warning for these cases. Since the tool is intended for Minecraft, I didn't add the .tplr|.twld which is used by TModLoader (a Terraria Mod Loader), but would be nice if it was there. Regardless, some verbosity changes and warnings have been amended.

@mazunki mazunki changed the title master Added warning for unsupported file types Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant