Test demonstrating a bug: merlin-destruct raises for some aliases to GADTs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm marking this as a draft pull request because it includes a stack trace and will thus have somewhat fragile output, so we shouldn't merge it. |
This was referenced Jan 5, 2024
|
Superceded by #38 , even though this isn't a fix for the underlying issue. |
|
So what should happen here? |
|
We can close this. (I didn't think it would show up anywhere, as it's a draft, but I see it shows up in at least my view of GitHub issues, so... let's close it.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
uis an alias to GADTt, then it's possible to arrange for merlin-destruct to raise on a term of type(x : u). This PR adds a test demonstrating as such.Unfortunately we have introduced this bug: it's not present in
ocaml/merlinat main or at the 501-preview branch.