proper migrate to hypertable #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extending `postgres.schema.DatabaseSchemaEditor` instead of `postgis.schema.PostGISSchemaEditor` - rename `drop_primary_key` -> `_drop_primary_key` and `create_hypertable` -> `_create_hypertable` - `_create_hypertable`: explictly calling `_drop_primary_key`, also added `should_migrate` arg - `_assert_is_hypertable` and `_assert_is_not_hypertable` methods added and integrated with `_create_hypertable` - `_set_chunk_time_interval` method added - override `add_field` and `alter_field` methods
|
Once approved will do same chages to "postgis" backend |
|
@schlunsen @bencleary Request you to review this. |
|
I have tested with |
|
@schlunsen the "migrate with fresh table" option discussed at #13 is not implemented but have kept a placeholder as of now. Will wait if someone requests for it. Created new issue #16 for it. |
|
README changes are pending too, will do that once code is reviewed. |
|
Looking good! |
|
Updated README and applied same changes to postgis schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated
TimescaleSchemaEditorfor postgres backendpostgres.schema.DatabaseSchemaEditorinstead ofpostgis.schema.PostGISSchemaEditordrop_primary_key->_drop_primary_keyandcreate_hypertable->_create_hypertable_create_hypertable: explictly calling_drop_primary_key, also addedshould_migratearg_assert_is_hypertableand_assert_is_not_hypertablemethods added and integrated with_create_hypertable_set_chunk_time_intervalmethod addedadd_fieldandalter_fieldmethods ofDatabaseSchemaEditorafter review
Closes #13