-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to Github Actions #426
base: main
Are you sure you want to change the base?
Conversation
Obviously this work depends on #425. Also, I added the .editorconfig because my IDE was being a pain. Happy to remove it if desired. |
a754fdd
to
ec03259
Compare
Put in a rudimentary shim in place to cater for nodejs 12. Low value, but low cost. Might be good to put babel in the build pipeline to add any needed polyfills instead of hand-rolling them. |
Alternately, the oldest version node.js actually maintains (found here) is 14, so dropping support for anything below that might be a solid option. |
I've removed the dependency on #425 so the node versions match those in the travis config, but I'd have to see about fixing the mocha execution issue mentioned before, since the exit code isn't propagated correctly at the moment. I'll add in one of the other changes I did to fix that, and see what I can do about downgrading mocha so it runs correctly. |
b30dd32
to
447b1a4
Compare
Ok, I give up. Fancy-pants browserslist scripting is just not meant to be. |
Using github actions to execute branch and PR testing.
Currently:
Had to mess around with the package locks, since the empty package name at the top causes a crash in versions below 16.