Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Github Actions #426

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Switching to Github Actions #426

wants to merge 3 commits into from

Conversation

Tzrlk
Copy link

@Tzrlk Tzrlk commented Apr 20, 2023

Using github actions to execute branch and PR testing.

Currently:

  • NodeJS 8 and 10 will require a mocha downgrade to function at all.
  • 12 and below won't work with the newer stdlib functions.
  • Everything else appears fine.

Had to mess around with the package locks, since the empty package name at the top causes a crash in versions below 16.

@Tzrlk
Copy link
Author

Tzrlk commented Apr 20, 2023

Obviously this work depends on #425.

Also, I added the .editorconfig because my IDE was being a pain. Happy to remove it if desired.

@Tzrlk Tzrlk force-pushed the ghactions branch 3 times, most recently from a754fdd to ec03259 Compare April 22, 2023 01:29
@Tzrlk
Copy link
Author

Tzrlk commented Apr 22, 2023

Put in a rudimentary shim in place to cater for nodejs 12. Low value, but low cost. Might be good to put babel in the build pipeline to add any needed polyfills instead of hand-rolling them.

@Tzrlk
Copy link
Author

Tzrlk commented Apr 22, 2023

Alternately, the oldest version node.js actually maintains (found here) is 14, so dropping support for anything below that might be a solid option.

@Tzrlk
Copy link
Author

Tzrlk commented Apr 24, 2023

I've removed the dependency on #425 so the node versions match those in the travis config, but I'd have to see about fixing the mocha execution issue mentioned before, since the exit code isn't propagated correctly at the moment. I'll add in one of the other changes I did to fix that, and see what I can do about downgrading mocha so it runs correctly.

@Tzrlk Tzrlk force-pushed the ghactions branch 20 times, most recently from b30dd32 to 447b1a4 Compare April 25, 2023 11:57
@Tzrlk
Copy link
Author

Tzrlk commented Apr 25, 2023

Ok, I give up. Fancy-pants browserslist scripting is just not meant to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant