Improved exception handling when a child process fails #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, if Jake fails due to a child process failing, the exception is very confusing. This is especially the case on Windows, where the "command not found" message takes up 2 lines.
This pull request changes how
Exec
handles errors by using a properError
object instead of merely concatenating the output ofstderr
. As a result,api.fail
will not attempt to build theError
object from scratch and potentially mutilate the child process's error message.Example (without patch):
Example (with patch):
Now, it is much more clear why the child process failed.