Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Karatsuba_Algorithm.php #2910

Merged
merged 2 commits into from
May 30, 2020
Merged

Added Karatsuba_Algorithm.php #2910

merged 2 commits into from
May 30, 2020

Conversation

JasbirCodeSpace
Copy link
Contributor

@JasbirCodeSpace JasbirCodeSpace commented May 12, 2020 •
edited
Loading

Fixes #2248

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Changes proposed in this pull request:

  • Added Karatsuba Algorithm in PHP

Languages Used:

  • PHP

Files Added:

  • Karatsuba_Algorithm.php

MastersAbh
MastersAbh approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@MastersAbh MastersAbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

MastersAbh
MastersAbh requested changes May 19, 2020
View reviewed changes
Karatsuba_Algorithm/Karatsuba_Algorithm.php Outdated
// 23984 183672
// Output:
// 4405189248
?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add one blank line at end of file

Copy link
Contributor Author

@JasbirCodeSpace JasbirCodeSpace May 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes have a look @MastersAbh @asha15 @raghav-dalmia

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MastersAbh @jainaman224 @somya-kapoor Please review this PR

@MastersAbh MastersAbh merged commit e7d5458 into jainaman224:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MastersAbh MastersAbh MastersAbh approved these changes

Assignees
No one assigned
Labels
GSSoC20 medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Karatsuba Algorithm
2 participants
@JasbirCodeSpace @MastersAbh