Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMP in C #2828

Merged
merged 2 commits into from
May 30, 2020
Merged

KMP in C #2828

merged 2 commits into from
May 30, 2020

Conversation

shreyakapoor08
Copy link
Contributor

@shreyakapoor08 shreyakapoor08 commented Apr 28, 2020

Fixes #2555

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Changes proposed in this pull request:

KMP in C added

Languages Used:

C

Files Added:

KMP.c

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

Copy link
Collaborator

@MastersAbh MastersAbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 space as indentation instead of TAB..rest looks fine

@shreyakapoor08
Copy link
Contributor Author

@MastersAbh Kindly check now

@shreyakapoor08 shreyakapoor08 force-pushed the knuth-moris branch 2 times, most recently from eda22a1 to e4a697a Compare May 10, 2020 18:53
Copy link
Collaborator

@somya-kapoor somya-kapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

///Sample OP:
// Pattern occurs with shift 3
// Pattern occurs with shift 9

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the line 71,72,73

KMP in C

Squashing commits

sample IP OP added

4 space indentation

4 space indentation corrected

removing 71 72 73 lines
@shreyakapoor08
Copy link
Contributor Author

@somya-kapoor Done. Kindly Review

Copy link
Collaborator

@MastersAbh MastersAbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be all. Please make this change and I will merge your PR.

Knuth_Morris_Pratt_Algorithm/KMP.c Outdated Show resolved Hide resolved
@shreyakapoor08
Copy link
Contributor Author

shreyakapoor08 commented May 20, 2020

@MastersAbh @somya-kapoor Kindly check

@MastersAbh MastersAbh merged commit ff15d7a into jainaman224:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knuth Morris Prat Algorithm
3 participants