Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Knuth Morris Pratt Algorithm in Kotlin #2814

Merged
merged 1 commit into from
May 12, 2020
Merged

Added Knuth Morris Pratt Algorithm in Kotlin #2814

merged 1 commit into from
May 12, 2020

Conversation

darkmatter18
Copy link
Contributor

Fixes #2555

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Changes proposed in this pull request:

  • Added Knuth Morris Pratt Algorithm in Kotlin

Languages Used:

  • Kotlin

Files Added:

  • KMP.kt

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

@darkmatter18
Copy link
Contributor Author

@jainaman224 @asha15 Please review this

Knuth_Morris_Pratt_Algorithm/KMP.kt Outdated Show resolved Hide resolved
Knuth_Morris_Pratt_Algorithm/KMP.kt Show resolved Hide resolved
Knuth_Morris_Pratt_Algorithm/KMP.kt Show resolved Hide resolved
@singh-shreya6
Copy link
Collaborator

Are you working on this?

@darkmatter18
Copy link
Contributor Author

@singh-shreya6 Please look at it

Copy link
Collaborator

@singh-shreya6 singh-shreya6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the change and then squash your commits.

Knuth_Morris_Pratt_Algorithm/KMP.kt Show resolved Hide resolved
@singh-shreya6
Copy link
Collaborator

Are you working on it?

Update KMP.kt

feat: added comments

Signed-off-by: Arkadip Bhattacharya <[email protected]>
@darkmatter18
Copy link
Contributor Author

@singh-shreya6 Sorry for this delay. Please review!

@singh-shreya6 singh-shreya6 merged commit 24c52a8 into jainaman224:master May 12, 2020
@darkmatter18
Copy link
Contributor Author

Thank you @singh-shreya6 for approving. Feeling so happy to contributing with you. 😊

Amitsharma45 pushed a commit to Amitsharma45/Algo_Ds_Notes that referenced this pull request May 31, 2020
Update KMP.kt

feat: added comments

Signed-off-by: Arkadip Bhattacharya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knuth Morris Prat Algorithm
2 participants