Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Karatsuba Algo in Dart #2616

Merged
merged 8 commits into from
Apr 14, 2020
Merged

Conversation

heisastark
Copy link
Contributor

@heisastark heisastark commented Mar 24, 2020

Fixes #2248

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Changes proposed in this pull request:

Added Kartasuba Algo in Dart

Languages Used:

Dart

Files Added:

Karatsuba_Algorithm.dart

Thanks!

Copy link
Collaborator

@asha15 asha15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

squash your commits and push it

Karatsuba_Algorithm/Karatsuba_Algorithm.dart Show resolved Hide resolved
Karatsuba_Algorithm/Karatsuba_Algorithm.dart Show resolved Hide resolved
@heisastark
Copy link
Contributor Author

@asha15 Ma'am, I'm unable to squash the commits as i fixed the issues directly from Github editor so no local copy is present

@asha15
Copy link
Collaborator

asha15 commented Apr 2, 2020

so you can clone the forked repo and squash it right?

This is a good chance for you to learn. let's give a try

@heisastark
Copy link
Contributor Author

heisastark commented Apr 2, 2020

@asha15 Squashing is creating many misc errors ma'am. I did try several times. If possible can you merge this branch or should I create a new PR with a single commit?

@heisastark heisastark requested a review from asha15 April 2, 2020 21:10
@asha15
Copy link
Collaborator

asha15 commented Apr 6, 2020

@heisastark

git rebase -i HEAD~

have you tried this command?

@heisastark
Copy link
Contributor Author

@asha15 Yes Ma'am. Even tried to force push and soft reset but no avail. Although, force push does squash the commits but adds misc files, which happened in the former case.

@heisastark
Copy link
Contributor Author

@asha15 Should i create a new PR?

@asha15 asha15 merged commit 007b6f9 into jainaman224:master Apr 14, 2020
Amitsharma45 pushed a commit to Amitsharma45/Algo_Ds_Notes that referenced this pull request May 31, 2020
* Sqashing 6 commits

* deleting accidentally added file

* deleting accidentally added file

* deleting accidentally added file

* deleting accidentally added file

* deleting accidentally added file

* deleting accidentally added file

* Karatsuba_Algorithm.dart added (accidently deleted while squashing commits)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karatsuba Algorithm
2 participants