Address comments idaholab#89

jain651 · Dec 9, 2020 · 880b9b4 · 880b9b4
1 parent c9b70b5
commit 880b9b4
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 65 deletions.
diff --git a/assessment/ASR_Validation/wald2017B/asr_concrete_block_calibration.i b/assessment/ASR_Validation/wald2017B/asr_concrete_block_calibration.i
@@ -30,84 +30,67 @@
   [./ASR_ex]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
-
   [./ASR_vstrain]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./ASR_strain_xx]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./ASR_strain_yy]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./ASR_strain_zz]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./ASR_strain_xy]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./ASR_strain_yz]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./ASR_strain_zx]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./volumetric_strain]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./thermal_strain_xx]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./thermal_strain_yy]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./thermal_strain_zz]
     order = CONSTANT
     family = MONOMIAL
-
   [../]
   [./thermal_conductivity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./thermal_capacity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./moisture_capacity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./humidity_diffusivity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./water_content]
     order = CONSTANT
     family = Monomial
@@ -124,8 +107,6 @@
 
 [Modules/TensorMechanics/Master]
   [./concrete]
-
-    # strain = SMALL
     strain = FINITE
     add_variables = true
     eigenstrain_names = 'asr_expansion thermal_expansion'
@@ -143,51 +124,42 @@
     type     = ConcreteThermalConduction
     variable = T
   [../]
-
   [./T_conv]
     type     = ConcreteThermalConvection
     variable = T
     relative_humidity = rh
   [../]
-
   [./T_adsorption]
     type     = ConcreteLatentHeat
     variable = T
     H = rh
   [../]
-
   [./rh_td]
     type     = ConcreteMoistureTimeIntegration
     variable = rh
   [../]
-
   [./rh_diff]
     type     = ConcreteMoistureDiffusion
     variable = rh
     temperature = T
   [../]
-
 []
 
 [AuxKernels]
   [./ASR_ex]
     type = MaterialRealAux
     variable = ASR_ex
-
     property = ASR_extent
     execute_on = 'timestep_end'
   [../]
   [./ASR_vstrain]
     type = MaterialRealAux
-
     variable = ASR_vstrain
     property = ASR_volumetric_strain
     execute_on = 'timestep_end'
   [../]
-
   [./ASR_strain_xx]
     type = RankTwoAux
-
     rank_two_tensor = asr_expansion
     variable = ASR_strain_xx
     index_i = 0
@@ -196,7 +168,6 @@
   [../]
   [./ASR_strain_yy]
     type = RankTwoAux
-
     rank_two_tensor = asr_expansion
     variable = ASR_strain_yy
     index_i = 1
@@ -205,47 +176,38 @@
   [../]
   [./ASR_strain_zz]
     type = RankTwoAux
-
     rank_two_tensor = asr_expansion
     variable = ASR_strain_zz
     index_i = 2
     index_j = 2
     execute_on = 'timestep_end'
   [../]
-
   [./ASR_strain_xy]
     type = RankTwoAux
-
     rank_two_tensor = asr_expansion
     variable = ASR_strain_xy
     index_i = 0
     index_j = 1
     execute_on = 'timestep_end'
   [../]
-
   [./ASR_strain_yz]
     type = RankTwoAux
-
     rank_two_tensor = asr_expansion
     variable = ASR_strain_yz
     index_i = 1
     index_j = 2
     execute_on = 'timestep_end'
   [../]
-
   [./ASR_strain_zx]
     type = RankTwoAux
-
     rank_two_tensor = asr_expansion
     variable = ASR_strain_zx
     index_i = 0
     index_j = 2
     execute_on = 'timestep_end'
   [../]
-
   [./thermal_strain_xx]
     type = RankTwoAux
-
     rank_two_tensor = thermal_expansion
     variable = thermal_strain_xx
     index_i = 0
@@ -254,7 +216,6 @@
   [../]
   [./thermal_strain_yy]
     type = RankTwoAux
-
     rank_two_tensor = thermal_expansion
     variable = thermal_strain_yy
     index_i = 1
@@ -263,22 +224,18 @@
   [../]
   [./thermal_strain_zz]
     type = RankTwoAux
-
     rank_two_tensor = thermal_expansion
     variable = thermal_strain_zz
     index_i = 2
     index_j = 2
     execute_on = 'timestep_end'
   [../]
-
   [./volumetric_strain]
     type = RankTwoScalarAux
     scalar_type = VolumetricStrain
     rank_two_tensor = total_strain
     variable = volumetric_strain
-
   [../]
-
   [./k]
     type = MaterialRealAux
     variable = thermal_conductivity
@@ -291,7 +248,6 @@
     property = thermal_capacity
     execute_on = 'timestep_end'
   [../]
-
   [./rh_capacity]
     type = MaterialRealAux
     variable = moisture_capacity
@@ -336,7 +292,6 @@
           36.6216574 34.53124 33.1736756 30.544127 26.0594134 24.5113073 23.5348264 20.5026548 17.5926252 16.6747727 18.7029892 18.5619608 15.8253731 13.8362956
           15.1902873 15.6208842 17.6491007 18.3728389 20.8847384 20.3479693 22.0537305 23.0852669 23.8236621 25.0603974 26.0333055 27.3627238 29.2674317 29.302288
           29.0733172 30.2514242 32.2974778 35.5810061 38.0635915 36.7499983 38.0307047 37.1936084'
-
   [../]
 
   [./ramp_humidity]
@@ -383,10 +338,8 @@
 []
 
 [Materials]
-
   [./concrete]
     type = PorousMediaBase
-
     # setup thermal property models and parameters
     # options available: CONSTANT ASCE-1992 KODUR-2004 EUROCODE-2004 KIM-2003
     thermal_conductivity_model =  KODUR-2004
@@ -499,7 +452,6 @@
   [./left]
     type = DirichletBC
     variable = disp_x
-    # boundary = cont_left
     boundary = '2000 2005'
     value = 0.0
   [../]

diff --git a/assessment/ASR_Validation/wald2017B/asr_concrete_block_validation_rebar.i b/assessment/ASR_Validation/wald2017B/asr_concrete_block_validation_rebar.i
@@ -31,7 +31,6 @@
     family = MONOMIAL
     block = 1
   [../]
-
   [./ASR_vstrain]
     order = CONSTANT
     family = MONOMIAL
@@ -91,22 +90,18 @@
     order = CONSTANT
     family = Monomial
   [../]
-
   [./thermal_capacity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./moisture_capacity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./humidity_diffusivity]
     order = CONSTANT
     family = Monomial
   [../]
-
   [./water_content]
     order = CONSTANT
     family = Monomial
@@ -119,7 +114,6 @@
     order = CONSTANT
     family = MONOMIAL
   []
-
   [./area]
     order = CONSTANT
     family = MONOMIAL
@@ -401,7 +395,6 @@
     type = ConstantAux
     block = '2'
     variable = area
-    # value = 3.8e-4
     value = 1.33e-4
     execute_on = 'initial timestep_begin'
   [../]
@@ -570,14 +563,12 @@
     type = ConcreteASRMicrocrackingDamage
     residual_youngs_modulus_fraction = 0.1
     block = 1
-    # outputs = Exodus
   []
   [./stress]
     type = ComputeMultipleInelasticStress
     block = 1
     inelastic_models = 'creep'
     damage_model = ASR_damage_concrete
-    # outputs = Exodus
   [../]
 
   [truss]
@@ -587,7 +578,6 @@
     temperature = T
     thermal_expansion_coeff = 11.3e-6
     temperature_ref = 10.6
-    # outputs = exodus
   []
 
 []

diff --git a/assessment/ASR_Validation/wald2017B/assessment b/assessment/ASR_Validation/wald2017B/assessment
@@ -1,6 +1,7 @@
 [Tests]
   issues = '#89'
-  requirement = 'Blackbear shall validate its multiphysics modeling capabilities'
+  requirement = 'BlackBear shall simulate accelerated alkali-silica reaction experiments on
+                 plain and reinforced concrete blocks, and adequately match experimental data.'
   design = 'ASR_validation/index.md'
 
   [./conc_time0]

diff --git a/assessment/ASR_Validation/wald2017B/tests b/assessment/ASR_Validation/wald2017B/tests
@@ -1,10 +1,7 @@
 [Tests]
   issues = '#89'
-  requirement = 'Blackbear shall be capable of appropriately modeling the expansion induced
-                 by alkali-silica reaction.'
-
+  requirement = 'Input files for alkali-silica reaction validation tests shall have valid syntax'
   design = 'ASR_validation/index.md'
-
   [./conc_calibration]
     type = RunApp
     input = 'asr_concrete_block_calibration.i'

diff --git a/doc/content/validation/ASR_validation/index.md b/doc/content/validation/ASR_validation/index.md
@@ -4,7 +4,7 @@ Alkalli-silica reaction in concrete significantly influences the expansion behav
 
 Various researchers have attempted to experimentally observe the ASR behavior in concrete and identify various criteria for ASR expansion. The validations cases in BlackBear are built based on such experiments. These cases not only focuses on the ASR expansion model, but also tests the multi-physics concrete modeling capability of BlackBear.
 
-## Benchmark Problem
+## Free Expansion of Plain Concrete
 
 [!cite](wallau2018asr) performed prism testing to assess the susceptibility of the concrete structure due to ASR. They demonstrated that the ASR expansion happens in three stages, initial swelling, acceleration, and consolidation of expansion, that is captured by a S-curve. They also showed that the curves could vary widely depending on the aggregate type and concluded that a globally applicable ASR expansion curve might not exist. The initial benchmark cases in Blackbear are built based on these experiments demonstrating how well the model can predict the experimental observations. The properties associated with the ASR extent calculation are tabulated below:
 
@@ -16,7 +16,7 @@ Various researchers have attempted to experimentally observe the ASR behavior in
 
 Here, the negative latency time indicates the aggregates are highly reactive. Refer to [ConcreteASREigenstrain](ConcreteASREigenstrain.md) and [!cite](wallau2018asr) for more details.
 
-## Assessment Problems
+## Free Expansion of Reinforced Concrete Blocks
 
 [!cite](wald_2017) performed a series of experiments to understand how the presence of multiaxial reinforcement affects ASR expansion behavior of concrete.
 Two of these experiments are included here as assessment cases: one unreinforced block (Specimen A1-000b), and one block with nine uniaxial bars oriented in the z-direction (Specimen A1-001a). The assessment cases also evaluate the effect of the environmental condition on the expansion behavior of the concrete.