-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow real time interaction with output of executing processes #6
base: master
Are you sure you want to change the base?
Conversation
@gggeek Looks cool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to modify the command based on the previous finished. So i would prefer to add events. Before and after.
But this would add a dependency to event-dispatcher.
@jagandecapri what do you think?
src/ProcessManager.php
Outdated
*/ | ||
public function runParallel(array $processes, $maxParallel, $poll = 1000) | ||
public function runParallel(array $processes, $maxParallel, $poll = 1000, $callback = null)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parser error ))
at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @gimler, thanks for your work. Your goal here is to "modify the command based on the previous finished". It looks like you are trying to accomplish a sequential process execution. This simple wrapper was meant for parallel processing. Let me know if there is something that I am missing from my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually i have 4 phantomjs instances and n testcases. Each phantom has his own port and should only execute one test a time.
So i must manipulate the command before when i know which phantom instance is free.
Actually i have three events before after and processing.
No description provided.