fix(backend): bug preventing signups with Fide, ECF, DWZ

backend/database/ratings.go

@@ -8,6 +8,7 @@ func getCohort(ratingSystem RatingSystem, currentRating int) DojoCohort {
 	case Ecf:
 		fallthrough
 	case Dwz:
+		fallthrough
 	case Knsb:
 		switch {
 		case currentRating < 300:

backend/user/ratings/ratings.go

@@ -269,8 +269,8 @@ func FetchDwzRating(dwzId string) (int, error) {
 
 	const ratingIndex = 13
 	tokens := strings.Split(string(b), "|")
-	if len(tokens) < ratingIndex {
-		err = errors.New(400, "Invalid request: DWZ API did not return a rating", "Tokens length less than 14")
+	if ratingIndex >= len(tokens) {
+		err = errors.New(400, "Invalid request: DWZ API did not return a rating", fmt.Sprintf("ratingIndex out of bounds for tokens %v", tokens))
 		return 0, err
 	}
 

backend/user/update/main.go

@@ -145,7 +145,7 @@ func fetchRatings(user *database.User, update *database.UserUpdate) error {
 	}
 
 	for system, rating := range *update.Ratings {
-		existingRating, _ := user.Ratings[system]
+		existingRating := user.Ratings[system]
 		if system != database.Custom && (existingRating == nil || rating.Username != existingRating.Username ||
 			rating.CurrentRating == 0 || rating.StartRating == 0) {
 			if err := fetchCurrentRating(rating, ratings.RatingFetchFuncs[system]); err != nil {
@@ -168,7 +168,7 @@ func handleAutopickCohort(user *database.User, update *database.UserUpdate) api.
 		return api.Failure(err)
 	}
 	if cohort := update.AutopickCohort(); cohort == database.NoCohort {
-		return api.Failure(errors.New(500, "Unable to choose cohort. Please contact support", fmt.Sprintf("Autopick cohort returned NoCohort for update %+v", update)))
+		return api.Failure(errors.New(500, "Unable to choose cohort. Please contact support", fmt.Sprintf("Autopick cohort returned NoCohort for update %#v", update)))
 	}
 
 	user, err := repository.UpdateUser(user.Username, update)