Added scripts for creating tables with logs #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rks, studentgroups, eventoccurrences)
Soctarian
requested review from
DmitryTkachenko,
BobTheSuperman,
apyura,
AccorDDD,
ArsenVlasov and
ArsenMaistryshyn
ArsenMaistryshyn
requested changes
Feb 23, 2022
| @@ -36,6 +36,8 @@ public class AccountService : IAccountService | |||
| Account user = await _unitOfWork.AccountRepository | |||
There was a problem hiding this comment.
please find more places where account is modified.
| @@ -0,0 +1,46 @@ | |||
| USE `Soft`; | |||
There was a problem hiding this comment.
please do dev testing
| @@ -0,0 +1,49 @@ | |||
| USE `Soft`; | |||
There was a problem hiding this comment.
please do dev testing
| @@ -0,0 +1,51 @@ | |||
| USE `Soft`; | |||
There was a problem hiding this comment.
please do dev testing
| @@ -17,5 +17,7 @@ public Course() | |||
| public virtual ICollection<MentorOfCourse> MentorsOfCourses { get; set; } | |||
|
|
|||
| public virtual ICollection<StudentGroup> StudentGroup { get; set; } | |||
|
|
|||
| public long UpdatedByAccountId { get; set; } | |||
There was a problem hiding this comment.
please set property where needed.
| @@ -33,7 +33,7 @@ public static void AddServices(this IServiceCollection services, IConfiguration | |||
|
|
|||
| services.AddHttpClient<IHttpUtil, HttpUtil>(client => | |||
| { | |||
| client.BaseAddress = new Uri(configuration.GetSection("Urls:Api:Https").Value); | |||
| entity.Property(e => e.UpdatedByAccountId) | ||
| .IsRequired() | ||
| .HasColumnName("UpdatedByAccountId") | ||
| .HasDefaultValueSql("1"); |
| CREATE TABLE `CoursesChanges` ( | ||
| `ID` BIGINT UNSIGNED NOT NULL AUTO_INCREMENT, | ||
| `CourseID` BIGINT UNSIGNED NOT NULL, | ||
| `OldName` TINYINT UNSIGNED DEFAULT NULL, |
There was a problem hiding this comment.
please set appropriate types
| @@ -0,0 +1,46 @@ | |||
| USE `Soft`; | |||
|
|
|||
| DROP TABLE IF EXISTS `CoursesChanges`; | |||
There was a problem hiding this comment.
please rename courses -> course
| `OldIsActive` BIT DEFAULT NULL, | ||
| `NewIsActive` BIT DEFAULT NULL, | ||
| `QueriedBy` BIGINT UNSIGNED NOT NULL, | ||
| `DateTime` DATETIME DEFAULT NOW(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added scripts for creating tables with logs. AccountChanges tab can log account ID of user, who disabled or enebled account. Other tabs arent provided with that feature, but have column in db for further adding this functional.
Change tabs were added for accounts, courses, homeworks, student groups and event occurrences.