Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Django 3 #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

WIP: Django 3 #39

wants to merge 6 commits into from

Conversation

g3rd
Copy link
Collaborator

@g3rd g3rd commented Jan 8, 2020 •
edited
Loading

  • Remove Python 2 support
  • Ensure usage with Django 3

See: #38

@g3rd g3rd self-assigned this Jan 8, 2020
@g3rd g3rd added this to the Python 3+ / Django 3 Support milestone Jan 8, 2020
@g3rd
Squashed commit of the following:
2b3b0a8 
commit 901687f
Author: Marc Laughton <[email protected]>
Date:   Wed Jan 8 14:27:51 2020 -0500

    Update setup py for pypi distribution (#26)

    * Add runtime for Python deployment and build tools, update Python version for Circle config

    * Update setup.py for more accurate PyPi info, test_suite path, and current package maintainer contact info

    * Isolate PR changes

    * 2.7.6 to 2.7.9 per master
@mattjegan
Copy link

@g3rd Is there anyway I can help here, I'd love to see this released.

@boris-lapouga
Copy link

@g3rd this seems relatively easy PR, any way this can be released or contributors can be instructed how to do it? I think a lot of projects depend on it and cannot migrate to Django 3.0 because of that library.

Any response is appreciated.

@tom-price tom-price self-requested a review September 16, 2020 19:11
tom-price
tom-price requested changes Sep 16, 2020
View reviewed changes
Copy link
Collaborator

@tom-price tom-price left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noted that these changes don't update the project version from 1.1.3 as set in __init__.py

Given the removal of support for Django 1.9 this should bump up to at least 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-price tom-price tom-price requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@g3rd g3rd

Labels
in progress
Projects
None yet
Milestone
Python 3+ / Django 3 Support
Development

Successfully merging this pull request may close these issues.
4 participants
@g3rd @mattjegan @boris-lapouga @tom-price