Enhance Update Class to Support Command Extraction from "callback_query" #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `getUpdate()->getMessage()->text` with `getUpdate()->getText()` to simplify text retrieval. - Improved `relevantMessageSubString` method to better handle different message formats and avoid potential errors.
- Updated `handler` method to handle `callback_query` updates. - Implemented command parsing for callback queries with format `/callback:::\w*`. - Maintained existing command parsing and execution for regular messages. - Ensured backward compatibility with previous command handling logic.
- Implemented `getText` method to retrieve text from various update types: - Returns message text for 'message', 'edited_message', 'channel_post', and 'edited_channel_post' types. - Returns formatted callback query data for 'callback_query' type. - Returns empty string for other types. - Updated docblocks to reflect the new method. - Maintained backward compatibility with deprecated methods.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1135 +/- ##
============================================
- Coverage 41.95% 41.09% -0.87%
- Complexity 614 616 +2
============================================
Files 133 133
Lines 1797 1803 +6
============================================
- Hits 754 741 -13
- Misses 1043 1062 +19 ☔ View full report in Codecov by Sentry. |
- Implemented `getText` method to retrieve text from various update types: - Returns message text for 'message', 'edited_message', 'channel_post', and 'edited_channel_post' types. - Returns formatted callback query data for 'callback_query' type. - Returns empty string for other types. - Updated docblocks to reflect the new method. - Maintained backward compatibility with deprecated methods.
irazasyed
requested changes
Oct 5, 2024
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "irazasyed/telegram-bot-sdk", | |||
| "name": "miladkhodaverdi23/telegram-bot-sdk", | |||
| @@ -3,6 +3,7 @@ | |||
| namespace Telegram\Bot\Commands; | |||
|
|
|||
| use Illuminate\Support\Collection; | |||
| use Mockery\Exception; | |||
| * @method static bool editForumTopic(array $params) | ||
| * @method static bool closeForumTopic(array $params) | ||
| * @method static bool reopenForumTopic(array $params) | ||
| * @method static bool deleteForumTopic(array $params) |
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| namespace Telegram\Bot\Methods; | |||
|
|
|||
| use Illuminate\Support\Arr; | |||
There was a problem hiding this comment.
Why is this removed? It's in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the Update class in the Telegram Bot SDK, allowing for the extraction of commands from
callback_queryupdates. The enhancement adds agetTextmethod that processes and retrieves command strings fromcallback queries, improving command handling efficiency.Changes
New
getTextMethod: Added to the Update class to handle command extraction fromcallback_queryupdates.Usage:
Example Keyboard
You can use inline keyboards to send callback queries:
Example Command Usage
Command class utilizing the new feature:
Please review the changes and provide any feedback or suggestions.
Thank you!