Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IPNS docs #1258

Merged
merged 19 commits into from
Sep 16, 2022
Merged

Improve IPNS docs #1258

merged 19 commits into from
Sep 16, 2022

Conversation

2color
Copy link
Member

@2color 2color commented Aug 24, 2022

Context

This is a significant rewrite of the IPNS docs addressing many of the repeated questions while providing an overview of the tradeoffs.

#1236

TODO

Preview

https://deploy-preview-1258--neon-choux-85b010.netlify.app/concepts/ipns/

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for neon-choux-85b010 ready!

Name Link
🔨 Latest commit 66251e7
🔍 Latest deploy log https://app.netlify.com/sites/neon-choux-85b010/deploys/631884b136f48e000bdd8658
😎 Deploy Preview https://deploy-preview-1258--neon-choux-85b010.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@2color 2color marked this pull request as ready for review August 29, 2022 18:02
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mishmosh mishmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. If there are any case studies or project codebases that nicely illustrate the tradeoffs you cover in the second half of this article, it might be nice to list examples.

Approving since my comments and suggestions are all non-blocking.

docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
@salmad3 salmad3 added the need/author-input Needs input from the original author label Sep 4, 2022
@filecorgi
Copy link
Contributor

  • Image optimization came back clean!
  • Vuepress build was successful!

@2color 2color merged commit 2916456 into main Sep 16, 2022
@2color 2color deleted the improve-ipns-docs branch September 16, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants