Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs/example #560

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kristian-nygaard-jensen

fs.add is not a function
"Invalid key type" key type must be specified

https://github.com/libp2p/js-libp2p/blob/main/packages/keychain/src/keychain.ts#L157

fix: docs/example

Description

Two function calls need to be modified for the examples to work.

Notes & open questions

I will try to write tests that prove the issues

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

fs.add is not a function
"Invalid key type" key type must be specified

https://github.com/libp2p/js-libp2p/blob/main/packages/keychain/src/keychain.ts#L157
@kristian-nygaard-jensen kristian-nygaard-jensen requested a review from a team as a code owner June 18, 2024 09:49
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this - can you please swap refs to RSA keys to use Ed25519 keys instead?

packages/ipns/README.md Outdated Show resolved Hide resolved
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the changes are not made to the index.ts files, they will be overwritten. can you make the modifications to the index.ts files so our doc gen updates the readme.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants