Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix httpx status check change #319

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 4, 2023

Latest httpx change the OK report from None to 200 OK status. While the current version of the tests will work with past version of httpx I'm pinning to modern versions for maintainability.

@ocefpaf ocefpaf force-pushed the fix_httpx_status_check_change branch from 1a511a8 to 7b56de7 Compare October 4, 2023 14:25
@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 4, 2023

Docs should not take that long... Something is amiss. I'll merge this to unblock #318 and investigate it later.

@ocefpaf ocefpaf merged commit d85363e into ioos:main Oct 4, 2023
15 of 16 checks passed
@ocefpaf ocefpaf deleted the fix_httpx_status_check_change branch October 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant