Improve exception handling in method to_iris #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Realise data by creating placeholder variable '_' - Don't use CubeList for placeholder variable
|
@vinisalazar let's just constrain our minimum iris version to the latest so we can remove the rest of the try-except. |
- In environment.yaml, pin iris version as >=3.3.0 This prevents errors in the `to_iris` methods
|
Thank you for the review @ocefpaf I added the minimum version to |
|
Can you try pinning netcdf4<1.6.1. I believe we are hitting Unidata/netcdf4-python#1192 |
vinisalazar
added a commit
to vinisalazar/erddapy
that referenced
this pull request
Sep 19, 2022
- Pin older version of netCDF4 to avoid Unidata/netcdf4-python#1192 - See ioos#268 for discussion
- Pin older version of netCDF4 to avoid Unidata/netcdf4-python#1192 - See ioos#268 for discussion
vinisalazar
force-pushed
the
iris_error
branch
from
ba54881
to
e65ce9f
Compare
|
I force-pushed a new commit that adds the netcdf4 pin to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a fix to the problem mentioned in #267.
On the
ERDDAP.to_iris()method, when thecubes.realise_data()method doesn't work, it realises the data by callingcube.data. The new versions of Iris prevent creating aCubeListobject usingcube.dataobjects (as they are Numpy Arrays and not cubes), so that behaviour was modified.Summary of changes:
_iris.cube.CubeListfor placeholder variableThanks,
Vini