Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VCR file #1115

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Update VCR file #1115

merged 1 commit into from
Oct 23, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 23, 2024

The server was updated and this should fix the failing integration test.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (54a9db3) to head (9099e73).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1115      +/-   ##
===========================================
- Coverage    82.08%   81.91%   -0.18%     
===========================================
  Files           25       25              
  Lines         5224     5224              
  Branches      1163     1163              
===========================================
- Hits          4288     4279       -9     
- Misses         634      644      +10     
+ Partials       302      301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 23, 2024

It is more robust to access the file directly like this instead of recording, hopefully we won't get kicked out of this ERDDAP server like it happened in the past.

@ocefpaf ocefpaf merged commit 67740b5 into ioos:develop Oct 23, 2024
26 of 27 checks passed
@ocefpaf ocefpaf deleted the integration_tests branch October 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant