Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes micromamba v2 failures #1111

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Fixes micromamba v2 failures #1111

merged 5 commits into from
Oct 4, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 4, 2024

Closes #1109

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (b67dfd9) to head (ae023d1).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1111      +/-   ##
===========================================
+ Coverage    81.79%   81.98%   +0.19%     
===========================================
  Files           25       25              
  Lines         5224     5224              
  Branches      1257     1257              
===========================================
+ Hits          4273     4283      +10     
+ Misses         644      633      -11     
- Partials       307      308       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 4, 2024

The failures are:

  1. Documentation: all NCEI URLs are down and/or unreliable at the moment.
  2. Integration tests are failing with:
=================================== FAILURES ===================================
___________________________ test_netcdf_content_type ___________________________

self = <compliance_checker.suite.CheckSuite object at 0x7f5432d85be0>
ds_str = 'https://gliders.ioos.us/erddap/tabledap/amelia-20180501T0000.ncCF?&time%3E=max(time)-1%20hour'

    def check_remote_netcdf(self, ds_str):
        if netcdf.is_remote_netcdf(ds_str):
            response = requests.get(ds_str, allow_redirects=True, timeout=60)
            try:
>               return Dataset(
                    urlparse(response.url).path,
                    memory=response.content,
                )

compliance_checker/suite.py:825: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
src/netCDF4/_netCDF4.pyx:2470: in netCDF4._netCDF4.Dataset.__init__
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   OSError: [Errno -51] NetCDF: Unknown file format: '/erddap/tabledap/amelia-20180501T0000.ncCF'

src/netCDF4/_netCDF4.pyx:2107: OSError

During handling of the above exception, another exception occurred:

cs = <compliance_checker.suite.CheckSuite object at 0x7f5432d85be0>

    @pytest.mark.vcr()
    def test_netcdf_content_type(cs):
        """
        Check that urls with Content-Type header of "application/x-netcdf" can
        successfully be read into memory for checks.
        """
        url = "https://gliders.ioos.us/erddap/tabledap/amelia-20180501T0000.ncCF?&time%3E=max(time)-1%20hour"
>       ds = cs.load_dataset(url)

compliance_checker/tests/test_protocols.py:31: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
compliance_checker/suite.py:817: in load_dataset
    return self.load_remote_dataset(ds_str)
compliance_checker/suite.py:845: in load_remote_dataset
    nc_remote_result = self.check_remote_netcdf(ds_str)
compliance_checker/suite.py:833: in check_remote_netcdf
    return Dataset(_nc)
src/netCDF4/_netCDF4.pyx:2470: in netCDF4._netCDF4.Dataset.__init__
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   OSError: [Errno -51] NetCDF: Unknown file format: '/tmp/compliance-checker_uikj9jaa.nc'

src/netCDF4/_netCDF4.pyx:2107: OSError
================ 1 failed, 11 passed, 233 deselected in 16.59s =================

Planing on merging this to get the CIs online. Both failures are unrelated to this change but will require it to be fixed in future PRs.

@ocefpaf ocefpaf merged commit 40940a7 into ioos:develop Oct 4, 2024
25 of 27 checks passed
@ocefpaf ocefpaf deleted the fix_umamba branch October 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant