Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #1068

Closed
wants to merge 2 commits into from
Closed

[pre-commit.ci] pre-commit autoupdate #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c79525
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] May 6, 2024
2457e07
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ repos:
- test_requirements.txt

- repo: https://github.com/psf/black
rev: 24.4.0
rev: 24.4.2
hooks:
- id: black
language_version: python3
Expand All @@ -31,12 +31,12 @@ repos:


- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.3.7
rev: v0.4.3
hooks:
- id: ruff

- repo: https://github.com/tox-dev/pyproject-fmt
rev: 1.7.0
rev: 1.8.0
hooks:
- id: pyproject-fmt

Expand Down
4 changes: 2 additions & 2 deletions compliance_checker/cf/cf_1_8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ def check_groups(self, ds: Dataset):
for attr in ginstance.ncattrs():
if attr in CF1_8Check.ROOT_GROUP_ONLY_ATTRS:
ctx_hi.messages.append(
f'§2.7.2 Attribute "{ attr }" MAY ONLY be used in the root group '
f'§2.7.2 Attribute "{ attr}" MAY ONLY be used in the root group '
"and SHALL NOT be duplicated or overridden in child groups.",
)

results.append(ctx_hi.to_result())

elif attr in CF1_8Check.NON_ROOT_GROUP_OPT:
ctx_lo.messages.append(
f"§2.7.2 Note: attribute '{ attr }' found on non-root group '{ gname }'. "
f"§2.7.2 Note: attribute '{ attr}' found on non-root group '{ gname}'. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is odd :-/ Let's skip this update for now and I'll investigate it later.

"This is optional for non-root groups. It is allowed in order to provide additional "
"provenance and description of the subsidiary data. It does not override "
"attributes from parent groups.",
Expand Down
Loading