-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow custom CF url (-d) #1066
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
41f221e
Allow specification of CF source by url
jr3cermak c17f5f6
Remove f-string specifier
jr3cermak e4f13f9
ruff recommended updates
jr3cermak a4819db
Updates with python black linter
jr3cermak b49f60f
Updates
jr3cermak 4ab682f
Updates
jr3cermak a6bb792
Removed items that pre-commit installs itself
jr3cermak 9069b06
Adjust workflow to use requirements-test.txt
jr3cermak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -289,7 +289,13 @@ def download_cf_standard_name_table(version, location=None): | |
if version == "latest": | ||
url = "http://cfconventions.org/Data/cf-standard-names/current/src/cf-standard-name-table.xml" | ||
else: | ||
url = f"http://cfconventions.org/Data/cf-standard-names/{version}/src/cf-standard-name-table.xml" | ||
if version.startswith('http'): | ||
url = version | ||
version = '"url specified"' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we could say "custom URL"? Although, if this variable is not used anywhere we can probably remove it here. |
||
else: | ||
url = f"http://cfconventions.org/Data/cf-standard-names/{}/src/cf-standard-name-table.xml".format( | ||
version | ||
) | ||
|
||
r = requests.get(url, allow_redirects=True) | ||
r.raise_for_status() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcermauwedu it seems that your core changes are in this commit, right? This is an easy merge IMO if you don't mind submitting just that in this PR and the rest in a linting one.