Final merge prior to 5.1.1 release #1062
Conversation
appearance of warnings even if there is nothing to warn
* base.py: Sometimes cfutil is None * protocols/netcdf.py: - Return False right away if content_type is None - Support extended type strings: "application/x-netcdf;ver=4" * suite.py: If text for xml fails, look for netcdf one more time * Convert suite.run() calls to suite.run_all() calls * Update hyrax url * Update thredds url * Add some development notes for troubleshooting tests with pytest using the vcr feature.
removed last of pkg_resources.
Some pytest fixes
Score fix in cf 1.6
|
Something possibly looks awry with compliance checker plugins. Investigating. |
Can you elaborate? The plugins tests are passing. The failure I can see is in |
Fixes loading initial available checkers via importlib. An invalid argument had been passed with kwarg `groups` instead of `group`.
Fixes a logic error in valid_range with valid_min/valid_max which resulted in erroneous results.
Renames check function `check_valid_range_or_valid_min_max_present` to `check_valid_range_and_valid_min_max_present` for clarity. Existing compliance checker plugins checked do not reference this function so this appears to be a safe operation.
|
pre-commit.ci fix |
|
@ocefpaf, uncovered a last minute bug in valid_range checks. I've forgotten how to issue the pre-commit black formatting fixes via GitHub Issues comments. Once this code has your approval as a reviewer, I will merge and draft a release, kicking off the PyPI build. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
I have a minor question above on the cfutil change but it is good to go IMO. |
Overrides `__dealloc__` method in `MockNetCDF` class to prevent suppress exception messages on tests via no-op/`pass` operation.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
No description provided.