Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to pyproject.toml #1024

Merged
merged 9 commits into from
Apr 11, 2024
Merged

move to pyproject.toml #1024

merged 9 commits into from
Apr 11, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 17, 2023

Work in progress and not ready for review.

This is the new standard for Python packaging but there are some details missing to accommodate everything we do in compliance-checker, like shipping scripts is deprecated won't be support for much longer.

@ocefpaf ocefpaf force-pushed the pyproject_toml branch 2 times, most recently from 7de648a to aaf5e1f Compare May 18, 2023 12:41
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (d3ee89b) to head (d53d227).
Report is 1 commits behind head on develop.

❗ Current head d53d227 differs from pull request most recent head e44eda1. Consider uploading reports for the commit e44eda1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1024   +/-   ##
========================================
  Coverage    82.18%   82.18%           
========================================
  Files           24       24           
  Lines         5171     5171           
  Branches      1242     1242           
========================================
  Hits          4250     4250           
  Misses         622      622           
  Partials       299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf ocefpaf marked this pull request as ready for review May 29, 2023 15:21
Comment on lines +14 to +18
maintainers = [
{name = "Dave Foster", email = "[email protected]"},
{name = "Benjamin Adams"},
{name = "Luke Campbell"},
{name = "Filipe Fernandes"},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjwadams are you OK with this change? Most projects are moving away from "author" in liue for maintainers.

Comment on lines +45 to +46
[project.scripts]
compliance-checker = "cchecker:main"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deprecated and in the future. We need a better solution to ship that script.

license-files = ["LICENSE"]
zip-safe = false
include-package-data = true
script-files = ["cchecker.py"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 11, 2024

Publishing to PyPI using Python 3.12 failed with:

ValueError: Require to set UDUNITS2_XML_PATH for a cf-units wheel build.

That is likely a problem with the cf_units wheel. I'll revert to use 3.11 b/c compliance-checker is pure Python but there is a change that folks using Python 3.12 will hit that issue.

@ocefpaf ocefpaf merged commit 7c7fa9d into ioos:develop Apr 11, 2024
23 checks passed
@ocefpaf ocefpaf deleted the pyproject_toml branch April 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant