feat(vue): support SSR #468
Conversation
christian-bromann
force-pushed
the
cb/vue-ssr-support
branch
from
7f5bbc6
to
8236c27
Compare
christian-bromann
force-pushed
the
cb/vue-ssr-support
branch
from
095b690
to
e984dec
Compare
christian-bromann
requested review from
gnbm,
tanner-reits and
sean-perkins
and removed request for
gnbm
| @@ -66,8 +66,12 @@ export const config: Config = { | |||
| hydrateModule: 'component-library/hydrate' | |||
| }), | |||
| vueOutputTarget({ | |||
There was a problem hiding this comment.
Should we have two Vue output target configs like we do for React?
There was a problem hiding this comment.
React and Vue projects are setup differently here. We have two output targets for React because we directly compile the components into their represented projects. With Vue we have setup an example project that just re-exports the components, and potentially more Vue related modules. That example project is imported by Nuxt and the Vite project. A bit different setup but it is actually how we see projects being organised.
FWIW I raised PR adding an example app using Vite + Vue, see #499. For that I've added an e2e test for this. For all these environments we now run a WebdriverIO tests that verifies that Stencil is properly able to hydrate the component, e.g. interacting with an input component with SSR support or without. While these tests are very rudimental, they are a start a least 😉 |
There was a problem hiding this comment.
No, it was part of the basic Nuxt setup. I can remove it.
* chore: re-org package structure * update deps in next project * lerna change * add back missing components dir * fix tests * fix react tests * fix types * run headless * ignore React type mismatch * build nextjs project alongside other projects * update unit test * fix(react): don't populate non-primitive objects (#498) * chore: re-org package structure * fix(react): don't populate non-primitive objects * test(vue): add playground for Vite+Vue (#499) * test(vue): add playground for Vite+Vue * ignore type issue
christian-bromann
force-pushed
the
cb/vue-ssr-support
branch
from
2c8d1e9
to
4ee8c6d
Compare
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently the Vue Output Target would not support SSR.
What is the new behavior?
This patch adds support for it. Furthermore:
@stencil/vue-output-targetas dependency to access runtime files (similar to React)hydrateModuleproperty to the output target that allows users to enable SSRDoes this introduce a breaking change?
Other information