fix(icon): verify the icon loads in the lifecycle

ionic-team · Sep 11, 2023 · 371c58f · 371c58f
1 parent 1b7e8aa
commit 371c58f
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/components/icon/icon.tsx b/src/components/icon/icon.tsx
@@ -12,6 +12,7 @@ export class Icon {
  private io?: IntersectionObserver;
  private iconName: string | null = null;
  private inheritedAttributes: { [k: string]: any } = {};
+ private didLoadIcon = false;
 
  @Element() el!: HTMLElement;
 
@@ -94,6 +95,12 @@ export class Icon {
  });
  }
 
+ componentDidLoad() {
+ if (!this.didLoadIcon) {
+ this.loadIcon();
+ }
+ }
+
  disconnectedCallback() {
  if (this.io) {
  this.io.disconnect();
@@ -138,6 +145,7 @@ export class Icon {
  // async if it hasn't been loaded
  getSvgContent(url, this.sanitize).then(() => (this.svgContent = ioniconContent.get(url)));
  }
+ this.didLoadIcon = true;
  }
  }